feat: add support for typing.Required, NotRequired #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, annotating a `TypedDict` field with one of the `Required` and `NotRequired` wrappers introduced in Python 3.11, dataclass-wizard would raise the following error: > TypeError: issubclass() arg 1 must be a class Fix that error by adding support for `Required` and `NotRequired`. Partially addresses issue rnag#121. [1] [1]: rnag#121
|
@rnag What can I do to help get this merged? |
|
@claui I'm afraid the fault lies with my general laziness and inattention to my projects 😅 Sorry for that. Just been busy with life. This looks good to merge for me, so I'll go ahead with it. Thanks again 🙏 for the huge help with |
|
Released in v0.24.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, annotating a
TypedDictfield with one of theRequiredandNotRequiredwrappers introduced in Python 3.11, dataclass-wizard would raise the following error:This pull request fixes that error by adding support for
RequiredandNotRequired.See also issue #121, part of which is addressed by this PR.