context in cron.Job.Run Is it possible?

[Breezess]

I want to pass in the context in cron.Job.Run, is there any way?

return cron.WithChain(func(job cron.Job) cron.Job {
	return cron.FuncJob(func() {
                // There is a way to write context 
                  job.Run()
                 // use context 
	})
})

[ex-tag]

@robfig

The AddFunc method should pass a context to the added function, as there might be websocket connections, or long-polling HTTP requests, that are open - and need to be cancelled when the task closes. Without this cancellation, these connections would remain open, and they would not be closed until the server was able to respond back, and therefore blocking additional connections that could be made. Please read https://go.dev/blog/context and https://pkg.go.dev/context for more information.

Example implementation

cron.New().AddFunc("", function (context c.Context) {

  request.Context(context)

})

Example source code change

func (c *Cron) AddFunc(spec string, cmd func(context c.Context)) error {
	return c.AddJob(spec, FuncJob(cmd))
}

[Slava02]

@robfig

Can you merge this pr?

#516

[tooptoop4]

robfig dipped out, dis abandonware ☠️

[flc1125]

Based on this project, I forked a project and kept the record of original historical submissions. At the same time, the 4.x version is under development, and if you are interested, you can join it together.
https://github.com/flc1125/go-cron

I added context.Context to this version, as well as error returns.

ex:

package main

import (
	"context"

	"github.com/flc1125/go-cron/v4"
	"github.com/flc1125/go-cron/v4/middleware/recovery"
)

func main() {
	c := cron.New()
	c.Use(recovery.New())

	c.AddFunc("* * * * * ?", func(ctx context.Context) error {
		panic("YOLO")
	})

	c.Start()
	defer c.Stop()
}

[flc1125]

V4.0.0 has been released, welcome to use it.👏🏻

[alaingilbert]

@Breezess I made a fork that addresses almost all issues of this repo.
https://github.com/alaingilbert/cron

This is how you could do what you want to do ->

_, _ = c.AddJob("* * * * * *", func(ctx context.Context) {
    // ...
})

[CybotTM]

Solution available in maintained fork

This feature has been implemented in netresearch/go-cron, a maintained fork of this library.

Implementation: Added JobWithContext interface for context.Context support:

// Jobs can implement JobWithContext for context-aware execution
type JobWithContext interface {
    RunWithContext(ctx context.Context)
}

// Usage:
ctx, cancel := context.WithCancel(context.Background())
c := cron.New(cron.WithContext(ctx))

c.AddJob("@every 1m", cron.FuncJobWithContext(func(ctx context.Context) {
    select {
    case <-ctx.Done():
        return // Graceful shutdown
    default:
        // Do work
    }
}))

The original Job interface is unchanged for backward compatibility. Jobs implementing only Job continue to work as before.

How to migrate:

// Change import from:
import "github.com/robfig/cron/v3"

// To:
import cron "github.com/netresearch/go-cron"

The API is 100% backward compatible. See the migration guide for details.

Related: netresearch#102