-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the Ability to Use Rectilinear Polygons in the Dynamic Zone Block #654
Conversation
inference/core/workflows/core_steps/transformations/dynamic_zones/v1.py
Outdated
Show resolved
Hide resolved
inference/core/workflows/core_steps/transformations/dynamic_zones/v1.py
Outdated
Show resolved
Hide resolved
@chandlersupple could you please follow up on @grzegorz-roboflow comments - otherwise it may not be pushed into next release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am approving this change, but I have one observation regarding interoperability of the block.
We claim the output is of kind list_of_values
which is true, but include_rectangle_details
changes the output data - making downstream blocks compatible or incompatible - depending on the value of this parameter. I am not sure how it ends up working - maybe that would be a problem, maybe not. @chandlersupple could you please monitor that over time and when we see people struggling with adoption of the block due to that inconsistency ping me to solve the problem.
262c2ee
@chandlersupple I moved all logic related to bounding rect into new block |
inference/core/workflows/core_steps/transformations/bounding_rect/v1.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add end-to-end test to integration tests and add to gallery
I agree this should be a separate block. Noticed that the output kind changed (was LIST_OF_VALUES via dynamic zone block, but new block has sv.detections as output); maybe that's what we want, but not sure what the desired use case is. @chandlersupple how / what is going to be using the rectangle data? Main thing I can think of is difference between predictions and zones (for e.g. time in zone block), maybe we can have a block to convert between these. |
Description
Added two optional parameters to the Dynamic Zone block allowing users to use rectangles instead of irregular polygons, and get the height, width, and angle of the rectangles.
Type of change
How has this change been tested, please provide a testcase or example of how you tested the change?
Passed all tests. Added the
test_calculate_minimum_bounding_rectangle
test.Any specific deployment considerations
N/A
Docs
N/A