Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image sizing after drop. Also improve zoom behavior. #16

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

brunopicinin
Copy link
Contributor

Description

Fix sizing of images dropped on canvas. Images should appear as big as possible, without overflowing the screen or scaling beyond factor of 1.

Import before PR:

Before.mp4

Import after PR:

After.mp4

Also fix zoom behavior to allow scaling to 100% of original size, instead of only 80%.

Before:

CleanShot 2024-09-23 at 01 03 08@2x

After:

CleanShot 2024-09-23 at 01 03 37@2x

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How has this change been tested, please provide a testcase or example of how you tested the change?

  • Imported multiple images with different aspect ratios to validate they always show as big as possible, without distorting the screen

@capjamesg capjamesg self-requested a review October 4, 2024 11:08
@capjamesg capjamesg merged commit c70d0eb into roboflow:main Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants