Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: reset state correctly when dropping a new image #17

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

brunopicinin
Copy link
Contributor

Description

When dropping a new image after drawing polygons on another one, the old annotations still show on the new image. This PR fixes that, now whenever a new image is dragged onto the canvas, the state is reset properly.

Before fix:

Before.mp4

After fix:

After.mp4

Also clear some old unused variables and comments.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How has this change been tested, please provide a testcase or example of how you tested the change?

  • Dragging an image to canvas
  • Annotating on this image
  • Dragging another image no top of that
  • Drawing new polygons on the new image and checking no old data is present

@capjamesg capjamesg merged commit 062f948 into roboflow:main Oct 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants