Skip to content

Added Confidence Argument to keypoint detection model #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

Greenstan
Copy link

@Greenstan Greenstan commented Jan 20, 2025

Description

A new "Confidence" argument has been added to the keypoint detection model (based on the confidence argument found in the object detection model)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How has this change been tested, please provide a testcase or example of how you tested the change?

A Dedicated keypoint detection model test file has been made with multiple test cases including one where the confidence is changed

Any specific deployment considerations

Docs

@CLAassistant
Copy link

CLAassistant commented Feb 4, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ Greenstan
✅ SolomonLake
❌ pre-commit-ci[bot]
You have signed the CLA already but the status is still pending? Let us recheck it.

@Greenstan Greenstan requested a review from SolomonLake June 5, 2025 18:17
@Greenstan Greenstan requested a review from SolomonLake July 4, 2025 17:12
Copy link
Contributor

@SolomonLake SolomonLake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you make sure you are running the tests locally using python3 -m unittest (or python) from the root of repo?

You can see test failures here: https://github.com/roboflow/roboflow-python/actions/runs/16078304796/job/45497459911?pr=354

I left suggested fixes which are all going to be necessary.

@Greenstan
Copy link
Author

@SolomonLake The Local path issues have been updated according to your suggestions as well as the switch to "with self.assertRaises(Exception):" and the env api-key variable.

@Greenstan Greenstan requested a review from SolomonLake August 8, 2025 13:35
@Greenstan Greenstan marked this pull request as draft August 8, 2025 18:23
@Greenstan Greenstan marked this pull request as ready for review August 8, 2025 18:26
@Greenstan
Copy link
Author

All tests are now successful. The issue was with some referenced file paths

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants