Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is related to Issue #926.
The idea is to add
ImageAssets
for download along side the already greatVideoAssets
.Type of change
This change is a non-breaking change.
How has this change been tested, please provide a testcase or example of how you tested the change?
To test the change you can install the assets submodule by running
pip install -e ".[assets]"
From there, test the new functionality with
Any specific deployment considerations
I did my best to change the documentation, but please call out anything I missed and I will update.
To simplify the code, I also included a "Assets" class, and each enum has a 'filename' and a 'hash' tied to it reduce verbosity of building out the "VIDEO_ASSETS" dictionary. Let me know if this isn't a good direction, and I can refactor. The customer facing behavior is still the same.
Docs
Changes to the the
docs/assets
and changes to docstrings in the function were changed.