Add arv_debug_enable() binding#26
Open
romainreignier wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This patch adds the binding for
arv_debug_enable()to allow to change the debug level from the code (instead of the env variableARV_DEBUG.This is my first Glib based binding contribution so I hope that my string conversion is correct.
I have tested this new function in a program and it worked as expected.
What I am unsure is it is necessary to protect the access behind the
Aravisinstance to avoid concurrent access?It seems necessary to me because it modifies a global variable here.
I have also fixed the older features definition. I have figured this out while trying to build with a pre-0.8.8 feature to unsure that my
#[cfg(feature)]tags are correct and I could not build the crate withv0_8_8andv0_8_6.