Fix compilation error in KdtreeBoundingBoxNearestNeighbors #102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the
swap
function implementation inKdtreeBoundingBoxNearestNeighbors
by updating the swapped member variables to match the actual class members.Changes
Before (incorrect swap members):
swap(this->mean, other.mean);
swap(this->metric, other.metric);
swap(this->samples, other.samples);
swap(this->root, other.root);
swap(this->values, other.values);
swap(this->var, other.var);
After (corrected to existing class members):
swap(this->boundingBox, other.boundingBox);
swap(this->metric, other.metric);
swap(this->checks, other.checks);
swap(this->root, other.root);
swap(this->values, other.values);
swap(this->nodeDataMax, other.nodeDataMax);
Reason
The previous implementation attempted to swap non-existent or outdated members (mean, samples, var), leading to build errors such as:
error: 'class rl::math::KdtreeBoundingBoxNearestNeighbors' has no member named 'var'
This PR corrects that by aligning the swapped fields with the actual member variables of the class.
Environment Tested
Windows 11 / Git Bash
GCC via MSYS2 / MinGW64
Manual build successful after fix