Fixed updater dialog crash..

- Markdown library Document is null on constructor (make bug report.)
rocksdanister · Feb 20, 2023 · 3afb8c9 · 3afb8c9
1 parent ecd7340
commit 3afb8c9
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/src/Lively/Lively.UI.WinUI/Views/Pages/Settings/SettingsSystemView.xaml b/src/Lively/Lively.UI.WinUI/Views/Pages/Settings/SettingsSystemView.xaml
@@ -17,7 +17,7 @@
                         VerticalAlignment="Top"
                         IsClosable="False"
                         IsOpen="True"
-                        Message="Development on hold"
+                        Message="This feature development is on hold"
                         Severity="Error">
                         <InfoBar.ActionButton>
                             <HyperlinkButton NavigateUri="https://github.com/rocksdanister/lively/issues/1569" ToolTipService.ToolTip="https://github.com/rocksdanister/lively/issues/1569">

diff --git a/src/Lively/Lively/Views/AppUpdater.xaml.cs b/src/Lively/Lively/Views/AppUpdater.xaml.cs
@@ -39,7 +39,7 @@ public AppUpdater(Uri fileUri, string changelogText)
             {
                 downloadBtn.IsEnabled = false;
                 this.Title = Properties.Resources.TextupdateCheckFail;
-                changelog.Document.Blocks.Add(new Paragraph(new Run(Properties.Resources.LivelyExceptionAppUpdateFail)));
+                changelog.Markdown = Properties.Resources.LivelyExceptionAppUpdateFail;
             }
         }
 
@@ -72,8 +72,7 @@ private void UpdateDownload_DownloadFileCompleted(object sender, bool success)
                 else
                 {
                     taskbarItemInfo.ProgressState = System.Windows.Shell.TaskbarItemProgressState.Error;
-                    changelog.Document.Blocks.Clear();
-                    changelog.Document.Blocks.Add(new Paragraph(new Run(Properties.Resources.LivelyExceptionAppUpdateFail)));
+                    changelog.Markdown = Properties.Resources.LivelyExceptionAppUpdateFail;
                     _forceClose = true;
                 }
             }));
@@ -131,8 +130,7 @@ private void Download_Button_Click(object sender, RoutedEventArgs e)
                 {
                     Logger.Error(ex);
                     taskbarItemInfo.ProgressState = System.Windows.Shell.TaskbarItemProgressState.Error;
-                    changelog.Document.Blocks.Clear();
-                    changelog.Document.Blocks.Add(new Paragraph(new Run(Properties.Resources.LivelyExceptionAppUpdateFail)));
+                    changelog.Markdown = Properties.Resources.LivelyExceptionAppUpdateFail;
                     _forceClose = true;
                 }
             }