Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lively on Windows 11 26002 and later #2050

Merged

Conversation

everything411
Copy link
Contributor

The WorkerW window we created is a child window of Progman window on Windows 11 Insider Canary build 26002 and later.
This pull request resolves #2030 #2047

Spy++ output

0x000100EC "Program Manager" Progman
  0x000100EE "" SHELLDLL_DefView
    0x000100F0 "FolderView" SysListView32
  0x00100B8A "" WorkerW       <-- This is the WorkerW instance we are after!

The WorkerW windows we created is a clild window of Progman on Windows 11 Insider Canary build 26002 and later

Spy++ output for 26002 and later
0x000100EC "Program Manager" Progman
  0x000100EE "" SHELLDLL_DefView
    0x000100F0 "FolderView" SysListView32
  0x00100B8A "" WorkerW       <-- This is the WorkerW instance we are after!
@CLAassistant
Copy link

CLAassistant commented Dec 23, 2023

CLA assistant check
All committers have signed the CLA.

@everything411
Copy link
Contributor Author

I'm not sure if 26002 is the minimum affected version because I'm already on 26016. The earliest bug report here is #2030 and it says 26002 is affected.

@everything411
Copy link
Contributor Author

@rocksdanister
Copy link
Owner

Good investigative work!

From what I understand Microsoft is trying to change the desktop implementation in the recent insider builds.
The changes may end up being different or never reach the final stable build, so checking version may not be a good idea:
Environment.OSVersion.Version.Build >= 26002

What if the first search fails we check for progman child Window as a fallback or something like that?

I don't have insider build with me at the moment, things to verify with this fix:

  1. Does wallpaper input (mouse/keyboard) still work.
  2. Does opening chatgpt, taskview and app switcher crash the wallpaper.
  3. Does the wallpaper pause algorithms still work properly.
  4. Does the wallpaper restore properly when explorer/workerw crash.

@everything411
Copy link
Contributor Author

  1. Does wallpaper input (mouse/keyboard) still work.
    mouse and keyboard work properly
  2. Does opening chatgpt, taskview and app switcher crash the wallpaper.
    taskview and app switcher do not crash the wallpaper. copilot is not available in my country so I cannot verify if it really works. but at least the copilot sidebar saying it is not available can show properly and the wallpaper does not crash.
  3. Does the wallpaper pause algorithms still work properly.
    I haven't checked every combination of these settings, but I think it can work properly.
  4. Does the wallpaper restore properly when explorer/workerw crash.
    the wallpaper restore properly after I kill explorer.exe and relaunch it

no longer do version checking
@rocksdanister rocksdanister merged commit 9142f6a into rocksdanister:core-separation Dec 28, 2023
@rocksdanister
Copy link
Owner

Looks like things changed again #2074

@shangsh
Copy link

shangsh commented Jan 16, 2024

Looks like things changed again #2074
So what's the solution?

@keshka
Copy link

keshka commented Mar 16, 2024

The issue persists on build 26080.ge_release.240308-1400

Repository owner locked as resolved and limited conversation to collaborators Mar 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants