fix: use GITHUB_OUTPUT for release changelog#25
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe release workflow now emits the multiline changelog to GITHUB_OUTPUT (using a CHANGES<<EOF ... EOF block) and the Release step reads that output instead of reading a temporary Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…ution
The `$(cat /tmp/changelog.txt)` in the `body` field of
softprops/action-gh-release is YAML, not shell — so it was rendered
as literal text instead of the actual changelog content.
Switch to the multiline GITHUB_OUTPUT heredoc syntax and reference it
via `${{ steps.changelog.outputs.CHANGES }}`.
c4a3cf4 to
7ac8310
Compare
|
Please take a look @rohitg00 :). |
Summary
bodyfield used$(cat /tmp/changelog.txt)which is shell command substitution — but inside YAML it's treated as literal text, so the release page shows$(cat /tmp/changelog.txt)instead of the actual changelog.GITHUB_OUTPUTheredoc syntax and reference the output via${{ steps.changelog.outputs.CHANGES }}so the changelog is correctly interpolated.Test plan
v2.0.0) and verify the generated GitHub Release body contains actual commit messages instead of$(cat /tmp/changelog.txt)Fix
Summary by CodeRabbit