Update v3 #128
Open
Update v3 #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianr
reviewed
Aug 18, 2025
src/Settings.php
Outdated
| esc_attr(trim($options['server_side_access_token'])) : | ||
| '', | ||
| 'client_side_access_token' => (!empty($options['client_side_access_token'])) ? | ||
| trim($options['client_side_access_token']) : |
|
|
||
| // Don't store default values in the database, so future updates to default values in the SDK get propagated. | ||
| foreach ($settings as $setting_name => $setting_value) { | ||
| if ($setting_value == Plugin::getInstance()->settingsInstance()->getDefaultOption($setting_name)) { |
templates/html/input/textInput.php
Outdated
| name="<?= esc_attr($input->getName()) ?>" | ||
| id="<?= esc_attr($input->getId()) ?>" | ||
| data-setting="<?= esc_attr($input->getId()) ?>" | ||
| value="<?= $input->getValue() ?>" |
templates/html/input/numberInput.php
Outdated
| name="<?= esc_attr($input->getName()) ?>" | ||
| id="<?= esc_attr($input->getId()) ?>" | ||
| data-setting="<?= esc_attr($input->getId()) ?>" | ||
| value="<?= $input->getValue() ?>" |
| ?> | ||
| <hr> | ||
| <div class="rollbar-settings-section-header"> | ||
| <h2 id="<?= $id ?>" class="section-heading"> |
templates/html/flashMessages.php
Outdated
| echo 'foo'; | ||
| foreach ($messages as $message) : ?> | ||
| <div class="notice notice-<?= $message['type'] ?> is-dismissible"> | ||
| <p><?= $message['message'] ?></p> |
| } catch (Exception $exception) { | ||
| FlashMessages::addMessage( | ||
| message: 'Rollbar is misconfigured. Please, fix your configuration here: <a href="' | ||
| . admin_url('/options-general.php?page=rollbar_wp') . '">', |
public/admin/rollbar.js
Outdated
| `<p><strong>PHP Test:</strong> There was a problem accessing Rollbar service.</p> | ||
| <ul> | ||
| <li>Code:<code>${data.code}</code></li> | ||
| <li>Message:<code>${data.message}</code></li> |
There was a problem hiding this comment.
Escape the data coming from the api?
templates/html/flashMessages.php
Outdated
| * }[] $messages | ||
| */ | ||
|
|
||
| echo 'foo'; |
|
Just a heads up: perhaps you can take a look at the implementation / fix for the security issue in #129. It also has a nice markdown file with security advises |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This is a major update the WordPress plugin. It includes an overhaul of most everything. Here is a high level list of everything that changed.
ROLLBAR_DISABLE_ADMINto remove the plugin settings page from the admin.ROLLBAR_SETTINGSto configure the plugin without the admin page.ROLLBAR_CLIENT_ACCESS_TOKENconstant or environment variable to set the client access token.WP_PROXY_BYPASS_HOSTS,WP_PROXY_USERNAME, andWP_PROXY_PASSWORDfor better proxy management.rollbar_api_admin_permissionfilter to allow custom authorization of the admin API.rollbar_disable_adminfilter to allow custom disabling of the admin page.rollbar_php_configfilter to allow more exact control over Rollbar PHP configurations.rollbar_telemetry_actionsfilter to allow control of which actions are logged via telemetry.rollbar_telemetry_custom_handlersfilter to allow custom control over what is logged in telemetry messages.Type of change
Related issues
Checklists
Development
Code review