Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Add Clerk auth support #410

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

jan-vdm
Copy link

@jan-vdm jan-vdm commented Aug 30, 2024

Description

Just adding support for Clerk authentication (https://clerk.com/) as I use it a lot and would be nice to have as part of my project scaffold.

Related Issue

N/A

Motivation and Context

The motivation behind this change is so that people have a baseline project start option for using Clerk as an authentication basis.

How Has This Been Tested?

  • Added a test for the mainstream popular line (clerk, expo-router, nativewind)
  • Manually tested each variation that included clerk (thank goodness for the do you want to delete existing project cli step)

Screenshots (if appropriate):

N/A

@danstepanov
Copy link
Collaborator

@jan-vdm is this ready for review? if so, can you request Danny review it?

@jan-vdm
Copy link
Author

jan-vdm commented Sep 3, 2024

@jan-vdm is this ready for review? if so, can you request Danny review it?

It is ready but I don't have the ability to add reviewers unfortunately

@dannyhw
Copy link
Collaborator

dannyhw commented Sep 3, 2024

will take a look soon :)

@danstepanov
Copy link
Collaborator

danstepanov commented Sep 8, 2024

@dannyhw bumping in case this slipped. I'll have time later this week to review if you're busy.

@dannyhw
Copy link
Collaborator

dannyhw commented Sep 8, 2024

Hey, sorry it's been a busy week haven't gotten around to it yet. I can take a look now.

@dannyhw
Copy link
Collaborator

dannyhw commented Sep 8, 2024

@jan-vdm thanks for taking the time to put this together first of all. And sorry I wasn't able to get to this sooner.

I have just tested this and it seems to be working, just one thing I want to ask

in clerks guide they suggest using expo-secure-store to configure the Token Cache, shouldn't we also add this to the setup here? Are there reasons to not add it?

@jan-vdm
Copy link
Author

jan-vdm commented Sep 9, 2024

@jan-vdm thanks for taking the time to put this together first of all. And sorry I wasn't able to get to this sooner.

I have just tested this and it seems to be working, just one thing I want to ask

in clerks guide they suggest using expo-secure-store to configure the Token Cache, shouldn't we also add this to the setup here? Are there reasons to not add it?

I mean I'm more than happy to add that in, didn't know how opinionated we wanted to go as you could use something else as the token cache. But I guess they could remove the dependency themself if that's the case.

@dannyhw
Copy link
Collaborator

dannyhw commented Sep 9, 2024

Personally I think we should be pretty opinionated and expo secure store would be the right choice from what I can tell.

@dannyhw
Copy link
Collaborator

dannyhw commented Oct 30, 2024

coming back to this again soon sorry for the delay

@jan-vdm
Copy link
Author

jan-vdm commented Nov 7, 2024

@dannyhw added the expo-secure-store to the template, haven't been able to test it though as I have a newborn hence why I've taken a while with this. Feel free to take it for a spin otherwise I'll test it when I next get time.

@dannyhw
Copy link
Collaborator

dannyhw commented Nov 7, 2024

Thanks, and congrats on your baby :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants