-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cli] Add Clerk auth support #410
base: main
Are you sure you want to change the base?
Conversation
@jan-vdm is this ready for review? if so, can you request Danny review it? |
It is ready but I don't have the ability to add reviewers unfortunately |
will take a look soon :) |
@dannyhw bumping in case this slipped. I'll have time later this week to review if you're busy. |
Hey, sorry it's been a busy week haven't gotten around to it yet. I can take a look now. |
@jan-vdm thanks for taking the time to put this together first of all. And sorry I wasn't able to get to this sooner. I have just tested this and it seems to be working, just one thing I want to ask in clerks guide they suggest using expo-secure-store to configure the Token Cache, shouldn't we also add this to the setup here? Are there reasons to not add it? |
I mean I'm more than happy to add that in, didn't know how opinionated we wanted to go as you could use something else as the token cache. But I guess they could remove the dependency themself if that's the case. |
Personally I think we should be pretty opinionated and expo secure store would be the right choice from what I can tell. |
coming back to this again soon sorry for the delay |
@dannyhw added the expo-secure-store to the template, haven't been able to test it though as I have a newborn hence why I've taken a while with this. Feel free to take it for a spin otherwise I'll test it when I next get time. |
Thanks, and congrats on your baby :) |
Description
Just adding support for Clerk authentication (https://clerk.com/) as I use it a lot and would be nice to have as part of my project scaffold.
Related Issue
N/A
Motivation and Context
The motivation behind this change is so that people have a baseline project start option for using Clerk as an authentication basis.
How Has This Been Tested?
Screenshots (if appropriate):
N/A