feat: add support for Unistyles 3.0 #456
Conversation
jpudysz
changed the title
|
putting a checklist here for my testing Expo Router:
React Navigation:
|
|
@jpudysz I got an error from running ios, seems related to nitromodules on |
|
Most likely you're on Xcode 16.2. |
|
@jpudysz ah yeah I am, whats the fix in that case? Just downgrading? |
|
If you add config plugin then it works on 16.2, but fails on 16.0. |
|
@dannyhw I trust you to merge when you feel this is good to go |
|
Maybe this doesn't make sense but is there a way we could check the version of xcode and apply the plugin if they have 16.2? if thats not viable then its not a big deal. I mean xcode breaking is a classic after all |
|
I don't think, so. Sadly there is no fix for now and it's on Apple 😢 |
|
thoughts on adding this is in the printoutput file if (stylingPackage?.name === 'unistyles' && os.type() === 'Darwin') {
const xcodeVersion = await runSystemCommand({
command: `xcodebuild -version | head -n 1 | awk '{print $2}'`,
errorMessage: 'failed to check xcode version',
stdio: 'pipe',
toolbox,
failOnError: false
});
const xcodeVersionString = String(xcodeVersion).trim();
if (xcodeVersionString === '16.2') {
warning(
'\nUnistyles is currently not compatible with xcode 16.2 due to an xcode bug, downgrade to 16.1 or lower to use Unistyles \nhttps://github.com/jpudysz/react-native-unistyles/issues/507'
);
}
}I can push this change up if its acceptable to you
|
|
Wow so cool!! |
|
ok added it :), I have to go out but will test downgrading xcode etc later today |
|
can confirm that xcode 16.1 is working as expected for |
| @@ -114,12 +111,12 @@ export default function NotFoundScreen() { | |||
| fontSize: 14, | |||
| color: '#2e78b7', | |||
| }, | |||
| }); | |||
| })); | |||
There was a problem hiding this comment.
An extra parentheses was added here which was breaking the tests. I will push a fix to remove. Just leaving this note to let you know what I changed.
| })); | |
| }); |
There was a problem hiding this comment.
Ah right, wrong template. It's for StyleSheet. Thanks for spotting it out
|
after making the one fix for stylesheet + expo router stack everything seems to be good to go |
Expo Router:
React Navigation:
Other:
@dannyhw @danstepanov PR is ready to be tested! I checked all UI templates mentioned above.
It would be good to merge it in a few days after I release
beta.8. It should land on Tue or Wed next week.