[Types] Upgrade types and include new required model card fields#2
[Types] Upgrade types and include new required model card fields#2
Conversation
vinaysrao1
left a comment
vinaysrao1
left a comment
There was a problem hiding this comment.
All comments are minor, approving.
src/index.ts
Outdated
| @@ -20,48 +21,104 @@ | |||
| const modelCard: ModelCard = { | |||
| modelName: 'COOP Integration Example', | |||
| version: '1.0.0', | |||
There was a problem hiding this comment.
There are a lot of versions here - making sure this is the version of the model card for this integration.
There was a problem hiding this comment.
And that it is OK to be 1.0.0 even though the types package has moved to 2.0.0. I think this is fine, would like your eyes on that.
There was a problem hiding this comment.
Actually updated all to 2.0 as this package was upgraded to 2.0 given types also changed,
src/index.ts
Outdated
| const manifest: IntegrationManifest = { | ||
| id: INTEGRATION_ID, | ||
| name: 'COOP Integration Example', | ||
| version: '1.0.0', |
package.json
Outdated
| ): Promise<{ outputType: typeof outputType; score: number }> { | ||
| // Returns a random number between 0 and 100. | ||
| // Because outputType is { scalarType: 'NUMBER' }, Coop can take the score and compare it to a threshold in the rule. | ||
| const score = Math.random() * 100; |
There was a problem hiding this comment.
Also a nit - readme and the comment in Line 218 above says score between 0 and 1
There was a problem hiding this comment.
Updated all to be 0-100. 0-1 may be hard and cause confusions around how many decimal points and such.
2 participants
No description provided.