Skip to content

[Vulnerabilities] Migrate from CRA Storybook to Vite compatible Storybook main#150

Merged
juanmrad merged 5 commits intomainfrom
storybook-vite-migration-cleanup-vulnerabilities
Mar 25, 2026
Merged

[Vulnerabilities] Migrate from CRA Storybook to Vite compatible Storybook main#150
juanmrad merged 5 commits intomainfrom
storybook-vite-migration-cleanup-vulnerabilities

Conversation

@juanmrad
Copy link
Member

@juanmrad juanmrad commented Mar 24, 2026

Context & Requests for Reviewers

Fixes #148

Migrate Storybook from CRA/webpack5 (broken on main) to Storybook 9 with the Vite builder, restoring a working storybook dev and storybook build. Remove 13 CRA packages and its transitive dependencies. Cleaning up dependency alerts to only 6 high secerity by npm audit.

Also fix minor UI bug that was bothering me:

Before:

Screenshot 2026-03-24 at 6 09 36 PM

After:
Screenshot 2026-03-24 at 6 10 46 PM

Copy link
Contributor

@vinaysrao1 vinaysrao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Color choice nit. Otherwise great work.

) : 'link' in props ? (
<Link
className="p-1 px-4 text-sm font-medium rounded cursor-pointer bg-coop-lightblue text-coop-blue hover:bg-coop-lightblue-hover w-fit"
className="inline-flex items-center gap-2 py-1 px-4 text-sm font-medium rounded-lg !no-underline !text-indigo-700 !bg-indigo-100 hover:!bg-indigo-200 w-fit"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, I am guessing there is a reason you are using indigo instead of coop tokens because the colors are not right.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted the button and was creating it again. I let copilot help with the classes 😓

@juanmrad juanmrad merged commit 027ba66 into main Mar 25, 2026
11 checks passed
@juanmrad juanmrad deleted the storybook-vite-migration-cleanup-vulnerabilities branch March 25, 2026 15:35
TomHawk123 pushed a commit to TomHawk123/coop that referenced this pull request Mar 26, 2026
…book main (roostorg#150)

* [Vulnerabilities] Migrate from CRA Storybook to Vite compatible Storybook main

* fix button

* fix betterer and eslint

* fix eslint

* use coop style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move out of CRA Storybook to Main Storybook.

2 participants