Conversation
vinaysrao1
approved these changes
Mar 25, 2026
Contributor
vinaysrao1
left a comment
There was a problem hiding this comment.
Color choice nit. Otherwise great work.
| ) : 'link' in props ? ( | ||
| <Link | ||
| className="p-1 px-4 text-sm font-medium rounded cursor-pointer bg-coop-lightblue text-coop-blue hover:bg-coop-lightblue-hover w-fit" | ||
| className="inline-flex items-center gap-2 py-1 px-4 text-sm font-medium rounded-lg !no-underline !text-indigo-700 !bg-indigo-100 hover:!bg-indigo-200 w-fit" |
Contributor
There was a problem hiding this comment.
Nit, I am guessing there is a reason you are using indigo instead of coop tokens because the colors are not right.
Member
Author
There was a problem hiding this comment.
I deleted the button and was creating it again. I let copilot help with the classes 😓
TomHawk123
pushed a commit
to TomHawk123/coop
that referenced
this pull request
Mar 26, 2026
…book main (roostorg#150) * [Vulnerabilities] Migrate from CRA Storybook to Vite compatible Storybook main * fix button * fix betterer and eslint * fix eslint * use coop style
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context & Requests for Reviewers
Fixes #148
Migrate Storybook from CRA/webpack5 (broken on main) to Storybook 9 with the Vite builder, restoring a working
storybook devandstorybook build. Remove 13 CRA packages and its transitive dependencies. Cleaning up dependency alerts to only 6 high secerity by npm audit.Also fix minor UI bug that was bothering me:
Before:
After:
