Fix ClickHouse outage crashing all dashboard pages#151
Merged
Conversation
juanmrad
requested review from
cassidyjames,
dom-notion,
julietshen,
pawiecz and
vinaysrao1
as code owners
vinaysrao1
approved these changes
Mar 25, 2026
Contributor
vinaysrao1
left a comment
vinaysrao1
left a comment
There was a problem hiding this comment.
nits about try - catch.
| user.orgId, | ||
| )) as any; | ||
| } catch { | ||
| return null; |
Member
Author
There was a problem hiding this comment.
This is intentional as to not crash the front-end with the error response. I'll add a console log so the back-end has a hint on the console, but otherwise this is intended.
| ); | ||
| return true; | ||
| } catch { | ||
| return false; |
…rns are to prevent front-end issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context & Requests for Reviewers
Fixes #145. When ClickHouse is down, every dashboard page crashed because analytics query errors propagated uncaught through resolvers and client components.
Added better handling of the clickhouse error. Also added a lightweight checker for health on clickhouse so we can properly show that the db is down.
Open to suggestions on the error messages there.