Skip to content

Use _is_spammy_exception for action_health metric filtering #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmttt merged 3 commits into from
Mar 25, 2026
Merged

Use _is_spammy_exception for action_health metric filtering #193

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07f27d4
Use _is_spammy_exception to filter actionable errors in action_health…
cmttt Mar 25, 2026
4a55af8
Fix formatting to match linter output
cmttt Mar 25, 2026
9a7fda9
Fix mypy: narrow BaseException to Exception for _is_spammy_exception
cmttt Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions osprey_worker/src/osprey/engine/executor/executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,18 +408,23 @@ def execute(

effects = context.get_effects()

total_errors = len(error_infos)
unexpected_errors = len(unexpected_error_infos)
actionable_error_infos = [
error_info
for error_info in error_infos
if isinstance(error_info.error, Exception) and not _is_spammy_exception(error_info.error)
]
has_effects = len(effects) > 0
has_actionable_errors = len(actionable_error_infos) > 0
action_tags = [
f'action:{action.action_name}',
f'had_errors:{total_errors > 0}',
f'had_unexpected_errors:{unexpected_errors > 0}',
f'had_actionable_errors:{has_actionable_errors}',
f'had_effects:{has_effects}',
]
metrics.increment('osprey.action_health', tags=action_tags)
if total_errors > 0:
metrics.histogram('osprey.action_error_count', total_errors, tags=[f'action:{action.action_name}'])
if has_actionable_errors:
metrics.histogram(
'osprey.action_error_count', len(actionable_error_infos), tags=[f'action:{action.action_name}']
)

result = ExecutionResult(
extracted_features=context.get_extracted_features(),
Expand Down
Loading