-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[meta] Return exec id of TRef, TRefArray and derived data members #18450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks a lot! Optional idea: could you add |
Test Results 18 files 18 suites 4d 4h 30m 21s ⏱️ Results for commit 62a9c3a. ♻️ This comment has been updated with latest results. |
Yes, I focussed on the functional change before. I'll make that part of the new version of the PR after the review. |
@olifre Do you happen to still have a reproducer/test for this issue of yours with a class CBTRef deriving from TRef, that you could share? |
Sadly, I have no example at hand 😢 . As far as I remember, I think I tried this in the context of a larger framework with classes inheriting from |
Instead of all data members the type of which has a name beginning with "TRef". Fixes ROOT-7052
Just added a test. |
" int i;\n" | ||
"ClassDef(Foo2, 1);\n" | ||
"};" | ||
"class TRefFoo {int i;};\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the name TRefFoo
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind this the point of the test :)
"class TRefFoo {int i;};\n" | |
"// We are testing that this is not confused for a ROOT TRef or TRefArray | |
"class TRefFoo {int i;};\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Instead of all data members the type of which has a name beginning with "TRef".
Fixes ROOT-7052
This PR builds on top of the solid work done here #14930.