Skip to content

[core] Add missing includes #18465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2025
Merged

Conversation

devajithvs
Copy link
Contributor

@devajithvs devajithvs commented Apr 22, 2025

This will fix build errors like:
error: declaration of 'type_info' must be imported from module 'std.std_typeinfo' before it is required

in #18369 when building with C++23

This Pull request:

Changes or fixes:

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

This PR fixes #

@devajithvs devajithvs self-assigned this Apr 22, 2025
Copy link

github-actions bot commented Apr 22, 2025

Test Results

    17 files      17 suites   4d 0h 5m 48s ⏱️
 2 727 tests  2 727 ✅ 0 💤 0 ❌
45 023 runs  45 023 ✅ 0 💤 0 ❌

Results for commit dc4e03c.

♻️ This comment has been updated with latest results.

Copy link
Member

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@devajithvs devajithvs added the clean build Ask CI to do non-incremental build on PR label Apr 23, 2025
@devajithvs devajithvs closed this Apr 23, 2025
@devajithvs devajithvs reopened this Apr 23, 2025
This will fix build errors like:
error: declaration of 'type_info' must be imported from module 'std.std_typeinfo' before it is required
@devajithvs devajithvs merged commit 43d6aef into root-project:master Apr 25, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clean build Ask CI to do non-incremental build on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants