[cppyy] Add converters and low-level views for fixed width integers #18492
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #17841
The support for the fixed-width types
int16_t
andint32_t
indeed diverges from upstream cppyy and usesunsigned long
which triggers the incorrect numpy view. Despite not having converters for the same, upstream relies on patches (or older behaviour) along theCppyy::ResolveName -> TClassEdit::ResolveTypedef
code path (see ResolveTypeDefImpl) that resolved fixed width integer types to their standard type counterparts (int16_t[][]
toshort[][]
andint32_t[][]
toint[][]
) when creating converters. Trying to follow the same code branch in ROOT can have a large blast radius in the type system. Two non-intrusive ways to fix this issue are either aliasing to existing short and int converters, or adding the converters and low-level views for both types. This PR performs the latter