Skip to content

[Windows] Fix warning C4477 + code formatting #18502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2025

Conversation

bellenot
Copy link
Member

Fix the following compilation warning on Windows:

IoBigEventGeneration.cxx(355): warning C4477: 'printf' : format string '%ld' requires an argument of type 'long', but variadic argument 1 has type 'unsigned __int64'
IoBigEventGeneration.cxx(355): note: consider using '%zd' in the format string

@bellenot bellenot requested a review from pcanal April 25, 2025 06:34
@bellenot bellenot self-assigned this Apr 25, 2025
@bellenot bellenot requested a review from dpiparo as a code owner April 25, 2025 06:34
@vepadulano
Copy link
Member

I merged this related PR #18495 so that we don't use the deprecated sprintf function anymore. I guess the error about the '%ld' format string will still be there, let's see after a rebase 👍 .

Fix the following warning:
IoBigEventGeneration.cxx(355): warning C4477: 'printf' : format string '%ld' requires an argument of type 'long', but variadic argument 1 has type 'unsigned __int64'
IoBigEventGeneration.cxx(355): note: consider using '%zd' in the format string
@bellenot bellenot force-pushed the fix-warning-C4477 branch from c3eb37d to 328882b Compare April 25, 2025 08:37
@bellenot
Copy link
Member Author

@vepadulano thanks! The PR has been rebased

Copy link

Test Results

    18 files      18 suites   4d 4h 49m 44s ⏱️
 2 731 tests  2 731 ✅ 0 💤 0 ❌
47 716 runs  47 716 ✅ 0 💤 0 ❌

Results for commit 328882b.

@bellenot bellenot merged commit 7aadb30 into root-project:master Apr 25, 2025
22 checks passed
@bellenot bellenot deleted the fix-warning-C4477 branch April 25, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants