[ntuple] remove GetCollectionInfo() from collection fields #19929
+7
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Several collection fields still had a public GetCollectionInfo() method. It was an oversight not to remove them earlier. These methods are unneeded and potentially dangerous to expose.
|
Aren't we supposed to deprecate them and remove them in 6.40 (or even 42 given what we said here for |
|
I think this case is different, because it is really a bug to have them in in the first place. So, if they are used (unlikely), I'd actually prefer to see breakage. |
silverweed
approved these changes
Sep 19, 2025
Test Results 21 files 21 suites 3d 17h 3m 10s ⏱️ For more details on these failures, see this check. Results for commit 47662b4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several collection fields still had a public GetCollectionInfo() method. It was an oversight not to remove them earlier. These methods are unneeded and potentially dangerous to expose.