[Minuit2] Typesafe strategy handling #20057
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Follows up on e1b4757, introducing the same strategy dependene in Fumili as in the main Minuit 2 implementation in VariableMetricBuilder.
It should not be possible to convert the MnStrategy object to an integer, because that means the strategy can be used in arbitrary ways inside the Minuit 2 algorithms. It would be better if all parameters dependent on the strategy can be retreived with explicit getter frunctions from the strategy object, such that all strategy dependence is clear just from reading the public interface. To be followed up by improving the documentation.
Settters are redundant, because if you want to create a certain strategy, then you can just use the constructor. Getters for the overall strategy level are unsafe, because they allow you to introduce strategy dependence in a way that is not explicitly clear from the public MnStrategy API.
guitargeek
force-pushed
the
mn_strategy
branch
from
2e354d3 to
d6d5964
Compare
Test Results 21 files 21 suites 3d 21h 4m 23s ⏱️ Results for commit d6d5964. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should not be possible to convert the MnStrategy object to an
integer, because that means the strategy can be used in arbitrary ways
inside the Minuit 2 algorithms.
It would be better if all parameters dependent on the strategy can be
retreived with explicit getter frunctions from the strategy object, such
that all strategy dependence is clear just from reading the public
interface.
To be followed up by improving the documentation.