[Math] Revert recent TMatrix optimizations #20771
Merged
+81
−123
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts the following two commits:
I merged these PRs believing that their addressing a real problem for ATLAS users, as muhammadalhroob is an ATLAS collaboration member.
However, I learned later in another PR by the same contributor that the point of the changes to TMatrix was just to try out AI. That made me have second thoughts about the TMatrix optimizations, and I would suggest to revert them at this point for several reasons:
I know that at least @silverweed is agreeing with the revert.
FYI, @muhammadalhroob. I hope you can understand the reasoning, and that this is nothing personal. We are ready to welcome and review your contributions to ROOT anytime! It was my totally mistake that I didn't ask about the motivation in your first PR.