Fix pixel conversion #20824
Merged
Fix pixel conversion #20824
+27
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Test Results 22 files 22 suites 3d 20h 48m 7s ⏱️ Results for commit 6d1673f. ♻️ This comment has been updated with latest results. |
bellenot
approved these changes
Jan 9, 2026
Member
bellenot
left a comment
bellenot
left a comment
There was a problem hiding this comment.
LGTM, after the suggested formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When converting a distance to pixel (fer instance a character height) some computational errors occurred. A 1 pixel error
showed up in the case described in this issue #20780
This PR fixes the problem.