A few minor fixes in roottest #20832
Merged
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 23 files 23 suites 4d 0h 57m 11s ⏱️ Results for commit 90fa494. ♻️ This comment has been updated with latest results. |
Macros are invoked with -e "#define xxx", but this list was not cleared, leading to a growing list of repeated defines when a test consists of multiple macros.
Since roottest-root-io-newstl-nolib is marked WILLFAIL, it was not noticed in root-project#18859 that e60640c introduced a function that does not exist. The test still fails, but that's a different issue to be investigated.
hageboeck
force-pushed
the
roottest-stuff
branch
from
0c6404f to
90fa494
Compare
Member
The 'best' action is to solve the problem of course :). Short of this we should make sure that there is an issue tracking the underlying problem (creating if not present yet, it could also be in JIRA) and keep the test as WILL FAIL (the intent there is that is a cheap way to be notified when we 'unintentionally' fix the issue. (The downside is indeed, the test decay where it can not tell whether we are seeing the original issue or something else :( ). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While tracing the problems addressed in #20818, I stumbled over a few small errors / warnings, which are fixed here.
What's a bit worrying is the test
roottest-root-io-newstl-nolib:When it was ported and re-enabled by @linev, it was already failing, see 1795466.
Afterwards, a non-existing function call was introduced in #18859, e60640c, such that the macro couldn't even be interpreted, any more. Due to the WILLFAIL annotation, this wasn't noticed.
Now we are back to the macro being interpreted, and failing during TTree::Scan with:
What should be the best action? Create an issue or disable/remove the test? @dpiparo @pcanal maybe?