[RF] Remove all RooDirItem::appendToDir calls. #21231
Open
+9
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 22 files 22 suites 3d 11h 21m 9s ⏱️ Results for commit 6bb90d9. |
In view of ROOT 7, I studied the effects of RooDirItem-derived classes. Since at least 5 years, RooDataHist, RooDataSet and RooFitResult were calling RooDirItem::appendToDir(this, true). This has no effect, since forceMemoryResident==true. Here, all these calls that don't have any effect are removed to make more obvious that no automatic registration is happening.
hageboeck
force-pushed
the
root7-ownership-13
branch
from
6bb90d9 to
8640519
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In view of ROOT 7, I studied the effects of
RooDirItem-derived classes. Since at least 5 years, RooDataHist, RooDataSet and RooFitResult were callingRooDirItem::appendToDir(this, true). This has no effect, sinceforceMemoryResident==true.Here, all these calls that don't have any effect are removed to make more obvious that no automatic registration is happening.