Generate list of hosted development sites after vagrant up
#1521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swalkinshaw
reviewed
Jun 13, 2024
lib/trellis/vagrant.rb
Outdated
Comment on lines
82
to
83
| sites = YAML.load_file(File.join(ANSIBLE_PATH, 'group_vars/development/wordpress_sites.yml')) | ||
| wordpress_sites = sites['wordpress_sites'] |
There was a problem hiding this comment.
This is already available as trellis_config.wordpress_sites
There was a problem hiding this comment.
trellis_config wasn't available so I loaded it the same way the Vagrantfile does.
There was a problem hiding this comment.
Did you actually get an error? This method is only used in the Vagrantfile which has trellis_config in scope.
If for some reason it doesn't work, you should change the post_up_message method to accept an trellis_config argument so it can be passed in.
There was a problem hiding this comment.
I did! Corrected per your suggestion.
swalkinshaw
reviewed
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.