Remove magrittr from imports#361
Merged
Merged
Conversation
2 in 1 gsub
2 in 1 gsub
mpadge
reviewed
Jun 11, 2025
mpadge
reviewed
Jun 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User code relaying on reexported pipe
%>%fromosmdatamust explicitly load it withlibrary(magrittr). Code examples, tests, and vignettes now use the pipe from base (|>) available since R 4.1. Using older versions will work, but the code from some examples and vignettes will need adjustments to run and is not supported.Apparently, we don't break any package as tested with revdep and the tests with devtools::check_win_oldrelease() use versions already supporting the base pipe.
FIX #358