Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix errors with ncbi_byname reported in #126 #132

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix errors with ncbi_byname reported in #126 #132

wants to merge 3 commits into from

Conversation

dlebauer
Copy link
Collaborator

@dlebauer dlebauer commented May 18, 2024 •
edited
Loading

Description

Fixes issues with ncbi_byname by

No new features

Related Issue

fix #126

@dlebauer
fix issue #129
dd308de 
Fixes issues with `ncbi_byname` by
- handling batch processing
- correcting data frame structure returned by `parse_ncbi` function.
- adding regression tests for  previously reported failed cases in #129.
@dlebauer dlebauer mentioned this pull request May 18, 2024
Open
dlebauer
dlebauer commented May 18, 2024
View reviewed changes
tests/testthat/test-ncbi.R Outdated Show resolved Hide resolved
dlebauer
dlebauer commented May 18, 2024
View reviewed changes
tests/testthat/test-ncbi.R Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

odd errors with sequence length queries at ncbi_byname
1 participant
@dlebauer