Skip to content

Conversation

@kuralme
Copy link

@kuralme kuralme commented Jan 8, 2026

A service interface to use with odometry set services. Related to #2096

@kuralme kuralme changed the title set odometry interface added set odometry interface for the new service Jan 8, 2026
Copy link
Member

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we really use a 6D-pose here?
With our robots, we only use a 2D pose like:
odometry_.setOdometry(pose.position.x, pose.position.y, tf2::impl::getYaw(q));

I just think of a debugging session where I desperately would try to guess the quaternion in the CLI ;)

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use a similar message like https://github.com/introlab/rtabmap_ros/blob/ros2/rtabmap_msgs%2Fsrv%2FResetPose.srv

@christophfroehlich regarding 6D pose, maybe it is better as it can also be used for the quadrupeds and bipeds

@christophfroehlich
Copy link
Member

I just don't like quaternions in human-accessible interfaces ;)

@saikishor
Copy link
Member

I just don't like quaternions in human-accessible interfaces ;)

Sure. I agree with quaternions. I also don't like them. I just referring to Euler angles.

@christophfroehlich
Copy link
Member

christophfroehlich commented Jan 8, 2026

I am fine with the current solution, but thinking again:

We could use a similar message like https://github.com/introlab/rtabmap_ros/blob/ros2/rtabmap_msgs%2Fsrv%2FResetPose.srv

@christophfroehlich regarding 6D pose, maybe it is better as it can also be used for the quadrupeds and bipeds

This comment goes in the same direction:

https://github.com/ros2/common_interfaces/blob/0134f04711e2b93eff3a4711eed91e3191b526b0/geometry_msgs/msg/Pose2D.msg#L4

should we instead use full 6D, but with RPY orientation and project it to the 2D pose?

@kuralme
Copy link
Author

kuralme commented Jan 8, 2026

Sorry i overlooked that part, I will add the remaining as well. Its a little bit more work for the user but better then quaternion i guess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants