-
Notifications
You must be signed in to change notification settings - Fork 78
set odometry interface for the new service #287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
christophfroehlich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we really use a 6D-pose here?
With our robots, we only use a 2D pose like:
odometry_.setOdometry(pose.position.x, pose.position.y, tf2::impl::getYaw(q));
I just think of a debugging session where I desperately would try to guess the quaternion in the CLI ;)
saikishor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could use a similar message like https://github.com/introlab/rtabmap_ros/blob/ros2/rtabmap_msgs%2Fsrv%2FResetPose.srv
@christophfroehlich regarding 6D pose, maybe it is better as it can also be used for the quadrupeds and bipeds
|
I just don't like quaternions in human-accessible interfaces ;) |
Sure. I agree with quaternions. I also don't like them. I just referring to Euler angles. |
|
I am fine with the current solution, but thinking again:
This comment goes in the same direction: should we instead use full 6D, but with RPY orientation and project it to the 2D pose? |
|
Sorry i overlooked that part, I will add the remaining as well. Its a little bit more work for the user but better then quaternion i guess |
A service interface to use with odometry set services. Related to #2096