[bug] Using UDP communication, some statements fail to match because line breaks are not cleanly filtered #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
evenator
reviewed
Jan 13, 2024
Collaborator
evenator
left a comment
evenator
left a comment
There was a problem hiding this comment.
Thanks for this contribution. I did a little bit of experimenting with this code, and I've proposed a small change.
| partial = "" | ||
| else: | ||
| full_lines = lines[:-1] | ||
| partial = lines[-1] |
Collaborator
There was a problem hiding this comment.
If there's no data decoded and partial is an empty string, lines will be an empty list, and this line will raise an IndexError.
Collaborator
There was a problem hiding this comment.
A solution would be to add a continue on line 84:
if not partial:
continue
4lon
reviewed
Feb 8, 2024
…ine breaks are not cleanly filtered
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the problem： #171
It's been tested in real life.