- 
                Notifications
    
You must be signed in to change notification settings  - Fork 231
 
Feature/vector object server #766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/vector object server #766
Conversation
Signed-off-by: Alberto Tudela <[email protected]>
Signed-off-by: Alberto Tudela <[email protected]>
Signed-off-by: Alberto Tudela <[email protected]>
Signed-off-by: Sushant Chavan <[email protected]>
f9f9d8d    to
    68f78ac      
    Compare
  
    Signed-off-by: Sushant Chavan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will need to check back in on this after the software PR is made so I can check that they align, but some small things we can fix now!
Most of the requested changes are just language fixes
| 
           I'm not sure if this PR belongs here, as there is a new one related to the Vector Object Server in the author's branch: Sushant-Chavan/navigation2#2. Could you please clarify, @Sushant-Chavan?  | 
    
| 
           I asked a similar question in another thread 😉 His company is picking up this work as they intend to use it in a product which was the main reason this work kind of sputtered off on my end prior - we didn't have an end user that could really battle test it to make sure we didn't have glaring gaps and put some real miles on it before merging into Nav2 itself.  | 
    
| 
           Hello @ajtudela & @SteveMacenski, This is in preparation for an upcoming PR that will soon be created to the https://github.com/ros-navigation/navigation2. The PR on my fork is a temporary one to make sure most of the CI checks pass before opening a PR upstream. It also allows me to get an early feedback from my team. I have to fix a few failing CI checks (DCO) before I can open the upstream PR. At that point, I will setup the correct PR references and mark this PR as ready for review :)  | 
    
Co-authored-by: Steve Macenski <[email protected]> Signed-off-by: Sushant Chavan <[email protected]>
…van/docs.nav2.org into feature/vector_object_server
Signed-off-by: Sushant Chavan <[email protected]>
17837c1    to
    bd1148d      
    Compare
  
    Signed-off-by: Sushant Chavan <[email protected]>
Signed-off-by: Sushant Chavan <[email protected]>
5d831d0    to
    f7e3a3b      
    Compare
  
    Signed-off-by: Sushant Chavan <[email protected]>
Signed-off-by: Sushant Chavan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small adjustments but largely approved! The content is complete, I think just some small shuffling needs to happen
Signed-off-by: Steve Macenski <[email protected]>
Signed-off-by: Steve Macenski <[email protected]>
Signed-off-by: Sushant Chavan <[email protected]>
Signed-off-by: Sushant Chavan <[email protected]>
Signed-off-by: Sushant Chavan <[email protected]>
This PR continues the work on the open but non-active PR #613
Minor cleanup and updates were made to refer to correspond to the changes in the feature PR