Skip to content

Conversation

@Sushant-Chavan
Copy link
Contributor

This PR continues the work on the open but non-active PR #613

Minor cleanup and updates were made to refer to correspond to the changes in the feature PR

Signed-off-by: Sushant Chavan <[email protected]>
@Sushant-Chavan Sushant-Chavan force-pushed the feature/vector_object_server branch from f9f9d8d to 68f78ac Compare August 14, 2025 09:31
Signed-off-by: Sushant Chavan <[email protected]>
Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will need to check back in on this after the software PR is made so I can check that they align, but some small things we can fix now!

Most of the requested changes are just language fixes

@ajtudela
Copy link
Contributor

I'm not sure if this PR belongs here, as there is a new one related to the Vector Object Server in the author's branch: Sushant-Chavan/navigation2#2.

Could you please clarify, @Sushant-Chavan?

@SteveMacenski
Copy link
Member

SteveMacenski commented Aug 15, 2025

I asked a similar question in another thread 😉 His company is picking up this work as they intend to use it in a product which was the main reason this work kind of sputtered off on my end prior - we didn't have an end user that could really battle test it to make sure we didn't have glaring gaps and put some real miles on it before merging into Nav2 itself.

@Sushant-Chavan
Copy link
Contributor Author

Hello @ajtudela & @SteveMacenski,

This is in preparation for an upcoming PR that will soon be created to the https://github.com/ros-navigation/navigation2. The PR on my fork is a temporary one to make sure most of the CI checks pass before opening a PR upstream. It also allows me to get an early feedback from my team.

I have to fix a few failing CI checks (DCO) before I can open the upstream PR. At that point, I will setup the correct PR references and mark this PR as ready for review :)

Sushant-Chavan and others added 3 commits August 21, 2025 14:30
Co-authored-by: Steve Macenski <[email protected]>
Signed-off-by: Sushant Chavan <[email protected]>
…van/docs.nav2.org into feature/vector_object_server
Signed-off-by: Sushant Chavan <[email protected]>
Signed-off-by: Sushant Chavan <[email protected]>
@Sushant-Chavan Sushant-Chavan force-pushed the feature/vector_object_server branch from 5d831d0 to f7e3a3b Compare August 22, 2025 11:25
@Sushant-Chavan Sushant-Chavan marked this pull request as ready for review August 22, 2025 12:13
Copy link
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small adjustments but largely approved! The content is complete, I think just some small shuffling needs to happen

Signed-off-by: Sushant Chavan <[email protected]>
@SteveMacenski SteveMacenski merged commit ee760b6 into ros-navigation:master Sep 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants