Update code to work with rolling #253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alejandro Hernandez Cordero <[email protected]>
jonbinney
approved these changes
Jan 18, 2026
Contributor
jonbinney
left a comment
jonbinney
left a comment
There was a problem hiding this comment.
Looks like the changes fall into a few categories:
- use hpp instead of h headers for tf2_ros, and update for small API changes
- create a rclcpp executor explicitly, since rclcpp::spin_some is deprecated
- whitespace changes (likely due to autoformatting)
Normally I'd want to avoid mixing white space and code changes in one PR, but the format changes are minimal and are all clearly better in this case.
Contributor
|
Thank you for fixing this @ahcorde ! Sorry i didn't catch it myself. |
Contributor
|
I assume this needs a new rolling releease to make the buildfarm happy? |
Contributor
Author
yes, that would be great |
Contributor
|
Released new version 2.3.2 to rolling: ros/rosdistro#49498 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related with https://build.ros2.org/view/Rdev/job/Rdev__laser_filters__ubuntu_noble_amd64/25/console