Merged
Conversation
cmake version < then 3.10 is deprecated
Guelakais
approved these changes
Aug 21, 2025
maspe36
reviewed
Aug 21, 2025
Contributor
maspe36
left a comment
maspe36
left a comment
There was a problem hiding this comment.
Hey thanks for the PR! Sorry for the delayed review.
It seems like other rosidl_generator_* packages moved to 3.12
https://github.com/ros2/rosidl/blob/humble/rosidl_generator_c/CMakeLists.txt#L1
Any particular reason we need to be on 3.20 instead of 3.12?
Contributor
Author
|
No. .. change to cmake min version 3.12 |
Guelakais
approved these changes
Sep 19, 2025
Guelakais
approved these changes
Sep 22, 2025
|
I've approved your pr it already. Is there a reason you asked me a second time for a review? |
Contributor
|
@Guelakais you're not a committer in the ros2-rust project, your reviews won't have any effect, @mosfet80 probably got confused because you approved this PR without having write permissions |
esteve
approved these changes
Sep 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cmake version < then 3.10 is deprecated