In setuptools packages, install everything in launch directory #5156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… consistent glob usage Signed-off-by: Emerson Knapp <[email protected]>
source/Tutorials/Beginner-Client-Libraries/Using-Parameters-In-A-Class-Python.rst
Outdated
Show resolved
Hide resolved
christophebedard
added
the
backport-all
fujitatomoya
approved these changes
Mar 24, 2025
…-A-Class-Python.rst Co-authored-by: Christophe Bedard <[email protected]> Signed-off-by: Emerson Knapp <[email protected]>
|
Done! |
christophebedard
approved these changes
Mar 25, 2025
mergify bot
pushed a commit
that referenced
this pull request
Mar 25, 2025
Signed-off-by: Emerson Knapp <[email protected]> Signed-off-by: Emerson Knapp <[email protected]> Co-authored-by: Christophe Bedard <[email protected]> (cherry picked from commit d002d60)
mergify bot
pushed a commit
that referenced
this pull request
Mar 25, 2025
Signed-off-by: Emerson Knapp <[email protected]> Signed-off-by: Emerson Knapp <[email protected]> Co-authored-by: Christophe Bedard <[email protected]> (cherry picked from commit d002d60) # Conflicts: # source/How-To-Guides/Developing-a-ROS-2-Package.rst # source/Tutorials/Intermediate/Launch/Using-ROS2-Launch-For-Large-Projects.rst
This was referenced Mar 25, 2025
christophebedard
pushed a commit
that referenced
this pull request
Mar 25, 2025
#5171) Signed-off-by: Emerson Knapp <[email protected]> Signed-off-by: Emerson Knapp <[email protected]> Co-authored-by: Christophe Bedard <[email protected]> (cherry picked from commit d002d60) Co-authored-by: Emerson Knapp <[email protected]>
christophebedard
added a commit
that referenced
this pull request
Mar 25, 2025
…ort #5156) (#5172) Signed-off-by: Emerson Knapp <[email protected]> Signed-off-by: Emerson Knapp <[email protected]> Co-authored-by: Christophe Bedard <[email protected]> (cherry picked from commit d002d60) Co-authored-by: Christophe Bedard <[email protected]>
Open
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5143
Instead of using "clever" glob pattern to match
launch.xml,launch.yaml,launch.py- just copy what we already recommend for CMake packages, and install everything fromlaunch/directory. Benefit of consistency between package types, and potentially leaving the door open for other launch suffixes/frontends.(also, make our usage of
globconsistent across the repo - we were some places usingos.path.joininside it, and sometimes not. I opted for the simpler syntax)