Skip to content

Commit c4b9081

Browse files
Ricardo Manríquezmorlov-apexai
Ricardo Manríquez
authored andcommitted
Added the option to set node name parameter from CLI
Signed-off-by: Ricardo Manríquez <[email protected]>
1 parent f26b4b5 commit c4b9081

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

ros2bag/ros2bag/verb/record.py

+5-1
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,10 @@ def add_arguments(self, parser, cli_name): # noqa: D102
174174
'--use-sim-time', action='store_true', default=False,
175175
help='Use simulation time.'
176176
)
177+
parser.add_argument(
178+
'--node-name', type=str, default='rosbag2_recorder',
179+
help='Specify the recorder node name. Default is rosbag2_recorder.'
180+
)
177181
self._subparser = parser
178182

179183
def main(self, *, args): # noqa: D102
@@ -259,7 +263,7 @@ def main(self, *, args): # noqa: D102
259263
recorder = Recorder()
260264

261265
try:
262-
recorder.record(storage_options, record_options)
266+
recorder.record(storage_options, record_options, args.node_name)
263267
except KeyboardInterrupt:
264268
pass
265269

rosbag2_py/src/rosbag2_py/_transport.cpp

+1-3
Original file line numberDiff line numberDiff line change
@@ -358,9 +358,7 @@ PYBIND11_MODULE(_transport, m) {
358358
py::class_<rosbag2_py::Recorder>(m, "Recorder")
359359
.def(py::init())
360360
.def(
361-
"record", &rosbag2_py::Recorder::record,
362-
py::arg("storage_options"),
363-
py::arg("record_options"),
361+
"record", &rosbag2_py::Recorder::record, py::arg(), py::arg(),
364362
py::arg("node_name") = "rosbag2_recorder")
365363
.def("cancel", &rosbag2_py::Recorder::cancel)
366364
;

0 commit comments

Comments
 (0)