Skip to content

Commit d3cb4e3

Browse files
authored
Add bindings to close method in PyReader and PyCompressionReader (#1935)
Signed-off-by: Øystein Sture <[email protected]>
1 parent 3c6ef95 commit d3cb4e3

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

rosbag2_py/rosbag2_py/_reader.pyi

+2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
class SequentialCompressionReader:
22
def __init__(self) -> None: ...
3+
def close(self) -> None: ...
34
def get_all_message_definitions(self, *args, **kwargs): ...
45
def get_all_topics_and_types(self, *args, **kwargs): ...
56
def get_metadata(self, *args, **kwargs): ...
@@ -14,6 +15,7 @@ class SequentialCompressionReader:
1415

1516
class SequentialReader:
1617
def __init__(self) -> None: ...
18+
def close(self) -> None: ...
1719
def get_all_message_definitions(self, *args, **kwargs): ...
1820
def get_all_topics_and_types(self, *args, **kwargs): ...
1921
def get_metadata(self, *args, **kwargs): ...

rosbag2_py/src/rosbag2_py/_reader.cpp

+2
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ PYBIND11_MODULE(_reader, m) {
8686
pybind11::overload_cast<
8787
const rosbag2_storage::StorageOptions &, const rosbag2_cpp::ConverterOptions &
8888
>(&PyReader::open))
89+
.def("close", &PyReader::close)
8990
.def("set_read_order", &PyReader::set_read_order)
9091
.def("read_next", &PyReader::read_next)
9192
.def("has_next", &PyReader::has_next)
@@ -109,6 +110,7 @@ PYBIND11_MODULE(_reader, m) {
109110
pybind11::overload_cast<
110111
const rosbag2_storage::StorageOptions &, const rosbag2_cpp::ConverterOptions &
111112
>(&PyCompressionReader::open))
113+
.def("close", &PyCompressionReader::close)
112114
.def("set_read_order", &PyCompressionReader::set_read_order)
113115
.def("read_next", &PyCompressionReader::read_next)
114116
.def("has_next", &PyCompressionReader::has_next)

0 commit comments

Comments
 (0)