Skip to content

Unit_testing #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Unit_testing #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0b9b6e2
done the tests
MTY621 Apr 6, 2025
83213a9
done the refactoring
MTY621 Apr 6, 2025
96abad1
really done the refactoring
MTY621 Apr 6, 2025
5318d60
done the .yaml hopefully
MTY621 Apr 6, 2025
df024b9
done the .yaml hopefully second try
MTY621 Apr 6, 2025
c53ab2c
done the .yaml hopefully third try
MTY621 Apr 6, 2025
e72325e
done the .yaml hopefully fourth try
MTY621 Apr 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,16 @@
name: Run Tests

on:
pull_request:

jobs:
test:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- name: Install dependencies
run: npm install

- name: Run Jest Tests
run: npm run test:jest
67 changes: 26 additions & 41 deletions app/gilded-rose.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ export class Item {
sellIn: number;
quality: number;

constructor(name, sellIn, quality) {
constructor(name: string, sellIn: number, quality: number) {
this.name = name;
this.sellIn = sellIn;
this.quality = quality;
Expand All @@ -19,51 +19,36 @@ export class GildedRose {

updateQuality() {
for (let i = 0; i < this.items.length; i++) {
if (this.items[i].name != 'Aged Brie' && this.items[i].name != 'Backstage passes to a TAFKAL80ETC concert') {
if (this.items[i].quality > 0) {
if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') {
this.items[i].quality = this.items[i].quality - 1
}
}
} else {
if (this.items[i].quality < 50) {
this.items[i].quality = this.items[i].quality + 1
if (this.items[i].name == 'Backstage passes to a TAFKAL80ETC concert') {
if (this.items[i].sellIn < 11) {
if (this.items[i].quality < 50) {
this.items[i].quality = this.items[i].quality + 1
}
}
if (this.items[i].sellIn < 6) {
if (this.items[i].quality < 50) {
this.items[i].quality = this.items[i].quality + 1
}
}
}
}
}
if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') {
this.items[i].sellIn = this.items[i].sellIn - 1;
this.items[i].sellIn -= 1;
}
if (this.items[i].sellIn < 0) {
if (this.items[i].name != 'Aged Brie') {
if (this.items[i].name != 'Backstage passes to a TAFKAL80ETC concert') {
if (this.items[i].quality > 0) {
if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') {
this.items[i].quality = this.items[i].quality - 1
}
}
} else {
this.items[i].quality = this.items[i].quality - this.items[i].quality
}
} else {
if (this.items[i].quality < 50) {
this.items[i].quality = this.items[i].quality + 1
}
if (this.items[i].name == 'Aged Brie') {
this.items[i].quality += 1
if (this.items[i].sellIn < 0) {
this.items[i].quality += 1
}
} else if (this.items[i].name == 'Backstage passes to a TAFKAL80ETC concert') {
this.items[i].quality += 1
if (this.items[i].sellIn < 0) {
this.items[i].quality = 0
} else if (this.items[i].sellIn < 6) {
this.items[i].quality += 2
} else if (this.items[i].sellIn < 11) {
this.items[i].quality += 1
}
} else if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') {
this.items[i].quality = this.items[i].quality - 1
if (this.items[i].sellIn < 0) {
this.items[i].quality -= 1
}
}
if (this.items[i].quality < 0) {
this.items[i].quality = 0
} else if (this.items[i].quality > 50 && this.items[i].name != 'Sulfuras, Hand of Ragnaros') {
this.items[i].quality = 50
}
}

return this.items;
}
}
}
Loading