Skip to content

Add support for Conjured items and update tests #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support for Conjured items and update tests #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"cSpell.words": [
"kata"
]
}
59 changes: 32 additions & 27 deletions app/gilded-rose.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,51 +19,56 @@ export class GildedRose {

updateQuality() {
for (let i = 0; i < this.items.length; i++) {
if (this.items[i].name != 'Aged Brie' && this.items[i].name != 'Backstage passes to a TAFKAL80ETC concert') {
if (this.items[i].quality > 0) {
if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') {
this.items[i].quality = this.items[i].quality - 1
const item = this.items[i];
const isConjured = item.name.toLowerCase().includes("conjured");

if (item.name !== 'Aged Brie' && item.name !== 'Backstage passes to a TAFKAL80ETC concert') {
if (item.quality > 0) {
if (item.name !== 'Sulfuras, Hand of Ragnaros') {
const degradation = isConjured ? 2 : 1;
item.quality -= degradation;
if (item.quality < 0) item.quality = 0;
}
}
} else {
if (this.items[i].quality < 50) {
this.items[i].quality = this.items[i].quality + 1
if (this.items[i].name == 'Backstage passes to a TAFKAL80ETC concert') {
if (this.items[i].sellIn < 11) {
if (this.items[i].quality < 50) {
this.items[i].quality = this.items[i].quality + 1
}
if (item.quality < 50) {
item.quality++;
if (item.name === 'Backstage passes to a TAFKAL80ETC concert') {
if (item.sellIn < 11 && item.quality < 50) {
item.quality++;
}
if (this.items[i].sellIn < 6) {
if (this.items[i].quality < 50) {
this.items[i].quality = this.items[i].quality + 1
}
if (item.sellIn < 6 && item.quality < 50) {
item.quality++;
}
}
}
}
if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') {
this.items[i].sellIn = this.items[i].sellIn - 1;

if (item.name !== 'Sulfuras, Hand of Ragnaros') {
item.sellIn--;
}
if (this.items[i].sellIn < 0) {
if (this.items[i].name != 'Aged Brie') {
if (this.items[i].name != 'Backstage passes to a TAFKAL80ETC concert') {
if (this.items[i].quality > 0) {
if (this.items[i].name != 'Sulfuras, Hand of Ragnaros') {
this.items[i].quality = this.items[i].quality - 1

if (item.sellIn < 0) {
if (item.name !== 'Aged Brie') {
if (item.name !== 'Backstage passes to a TAFKAL80ETC concert') {
if (item.quality > 0) {
if (item.name !== 'Sulfuras, Hand of Ragnaros') {
const degradation = isConjured ? 2 : 1;
item.quality -= degradation;
if (item.quality < 0) item.quality = 0;
}
}
} else {
this.items[i].quality = this.items[i].quality - this.items[i].quality
item.quality = 0;
}
} else {
if (this.items[i].quality < 50) {
this.items[i].quality = this.items[i].quality + 1
if (item.quality < 50) {
item.quality++;
}
}
}
}

return this.items;
}
}
}
100 changes: 61 additions & 39 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
"rimraf": "~3.0.2",
"source-map-support": "^0.5.20",
"ts-jest": "^27.0.7",
"ts-node": "^10.4.0",
"ts-node": "^10.9.2",
"tsconfig-paths": "^3.11.0",
"typescript": "^4.4.4"
"typescript": "^4.9.5"
}
}
30 changes: 21 additions & 9 deletions test/jest/gilded-rose.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,37 @@
import { Item, GildedRose } from '@/gilded-rose';

describe('Gilded Rose', () => {
it('should foo', () => {
it('should keep the same name', () => {
// Arrange
const gildedRose = new GildedRose([new Item('foo', 0, 0)]);

// Act
const items = gildedRose.updateQuality();

// Assert
expect(items[0].name).toBe('bar');
expect(items[0].name).toBe('foo');
});

it('sword quality drops by 1', () => {
// Arrange
const gildedRose = new GildedRose([new Item('Sword', 1, 1)]);
// Arrange
const gildedRose = new GildedRose([new Item('Sword', 1, 10)]);

// Act
const items = gildedRose.updateQuality();

// Act
const items = gildedRose.updateQuality();
// Assert
expect(items[0].quality).toBe(9);
});

// Assert
expect(items[0].quality).toBe(1);
})
it('conjured item quality drops by 2 before sell date', () => {
const gildedRose = new GildedRose([new Item('Conjured Mana Cake', 3, 6)]);
const items = gildedRose.updateQuality();
expect(items[0].quality).toBe(4);
});

it('conjured item quality drops by 4 after sell date', () => {
const gildedRose = new GildedRose([new Item('Conjured Bread', 0, 6)]);
const items = gildedRose.updateQuality();
expect(items[0].quality).toBe(2);
});
});