Skip to content

Changes Rack::File to Rack::Files #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

aseroff
Copy link

@aseroff aseroff commented Jul 8, 2024

Seems to work for me, and solves #126

Rack::Files was introduced in Rack 2.1
@rossta
Copy link
Owner

rossta commented Jul 22, 2024

@aseroff Thank you for your PR. I can’t merge until we can show the tests are passing in CI. It looks like the Circle CI integration stopped working—I might want to have the project switched to Github Actions and to bump the supported Rails versions to 6 and 7.

@rossta
Copy link
Owner

rossta commented Jul 22, 2024

I’ve started a draft PR to set up CI. I could use help fixing failing tests. #128

@aseroff
Copy link
Author

aseroff commented Jul 23, 2024

I’ve started a draft PR to set up CI. I could use help fixing failing tests. #128

I don't think I can add to your draft, but I sorted out 4 of the 5 failing tests. See this.

@aseroff aseroff changed the title Update sprockets_handler.rb Changes Rack::File to Rack::Files Jul 23, 2024
@cardmagic
Copy link

Any way we can get this working again? It's been 269 days since the last update and this is still a big problem.

@aseroff
Copy link
Author

aseroff commented Apr 21, 2025

Any way we can get this working again? It's been 269 days since the last update and this is still a big problem.

Not up to me, unfortunately. I ended up just migrating to the Rails 8 PWA approach and removing this dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants