-
-
Notifications
You must be signed in to change notification settings - Fork 638
docs: add operations guide and docs updates #675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add operations guide and docs updates #675
Conversation
|
I created this PR from the wrong branch (it includes OAuth/auth changes). Closing it and opening a docs-only replacement shortly. |
Summary of ChangesHello @jroth1111, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a comprehensive overhaul of the application's OAuth authentication infrastructure. The core objective is to create a more robust, maintainable, and user-friendly authentication experience by centralizing common OAuth patterns. This is achieved through the development of new Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This is an impressive and substantial refactoring of the authentication and OAuth flows. The introduction of the oauthflow, oauthhttp, and refresher packages provides a robust, reusable, and much cleaner abstraction for handling various authentication mechanisms. Centralizing the logic for OAuth flows, HTTP retries, and background token refreshing is a significant improvement for maintainability and correctness. The code is now more secure and less prone to bugs related to concurrency and resource management. I've included a couple of suggestions to reduce minor code duplication, but overall, this is excellent work.
Supersedes #665. This PR keeps docs-only changes and consolidates routing examples in docs/operations.md; no config.example.yaml changes.