feat(logging): disambiguate OAuth credential selection in debug logs #763
Conversation
When multiple OAuth providers share an account email, the existing "Use OAuth" debug lines are ambiguous and hard to correlate with management usage stats. Include provider, auth file, and auth index in the selection log, and only compute these fields when debug logging is enabled to avoid impacting normal request performance. Before: [debug] Use OAuth [email protected] for model gemini-3-flash-preview [debug] Use OAuth [email protected] (project-1234) for model gemini-3-flash-preview After: [debug] Use OAuth provider=antigravity auth_file=antigravity-user_example_com.json auth_index=1a2b3c4d5e6f7788 account="[email protected]" for model gemini-3-flash-preview [debug] Use OAuth provider=gemini-cli [email protected] auth_index=99aabbccddeeff00 account="[email protected] (project-1234)" for model gemini-3-flash-preview
Summary of ChangesHello @mvelbaum, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the clarity of debug logs related to OAuth credential selection. By adding specific details like the provider, authentication file, and index, it resolves issues where multiple OAuth accounts with the same email could lead to ambiguous log entries. The changes are implemented with performance in mind, ensuring that the additional information is only processed when debug logging is active. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request improves debug logging for OAuth credential selection by adding more context, such as provider, auth file, and auth index. The change to compute this information only when debug logging is enabled is a good performance optimization.
My review includes a couple of suggestions to improve maintainability and robustness:
- Refactoring the duplicated logging logic into a helper function.
- Safely quoting account information in the log message to handle special characters.
Overall, this is a valuable enhancement for debugging authentication issues.
Use strconv.Quote when embedding the OAuth account in debug logs so unexpected characters (e.g. quotes) can't break key=value parsing.
Extract repeated debug logging for selected auth credentials into a helper so execute, count, and stream paths stay consistent.
Avoid re-creating the request-scoped log entry in the helper and use a switch for account type dispatch.
Reduce duplicate Debugf calls by appending proxy info via an optional suffix and keep the debug-level guard inside the helper.
|
@luispater this is a minor change, but it was very helpful to me when setting things up for the first time. |
1 participant
When multiple OAuth providers share an account email, the existing "Use OAuth" debug lines are ambiguous and hard to correlate with management usage stats. Include provider, auth file, and auth index in the selection log, and only compute these fields when debug logging is enabled to avoid impacting normal request performance.
Before:
After: