fix(gemini): abort default injection on existing thinking keys #862
Conversation
Summary of ChangesHello @hkfires, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a refinement to how Gemini thinking configurations are applied, specifically addressing the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to prevent the default injection of 'thinking' keys if they already exist in the request body. The changes correctly add checks for existing includeThoughts or include_thoughts keys before setting a default value. While this fixes the overwriting issue, it introduces a new problem by removing the key normalization logic. For example, Gemini 3 models expect includeThoughts (camelCase), but the new code will allow include_thoughts (snake_case) to pass through, which the API might ignore. This normalization issue is present in all four modified functions. Additionally, there is significant code duplication across these functions that could be refactored into a helper function for better maintainability.
| if !gjson.GetBytes(updated, "generationConfig.thinkingConfig.includeThoughts").Exists() && | ||
| !gjson.GetBytes(updated, "generationConfig.thinkingConfig.include_thoughts").Exists() { | ||
| valuePath := "generationConfig.thinkingConfig.include_thoughts" | ||
| rewritten, err := sjson.SetBytes(updated, valuePath, *incl) | ||
| if err == nil { | ||
| updated = rewritten | ||
| } | ||
| } |
There was a problem hiding this comment.
This change correctly prevents overwriting an existing includeThoughts key. However, it misses an opportunity for normalization. This function is for models that expect include_thoughts (snake_case). If a request contains includeThoughts (camelCase), this logic allows it to pass through unmodified. The API might ignore this setting if it strictly expects snake_case. It would be more robust to normalize the key to include_thoughts.
| if !gjson.GetBytes(updated, "request.generationConfig.thinkingConfig.includeThoughts").Exists() && | ||
| !gjson.GetBytes(updated, "request.generationConfig.thinkingConfig.include_thoughts").Exists() { | ||
| valuePath := "request.generationConfig.thinkingConfig.include_thoughts" | ||
| rewritten, err := sjson.SetBytes(updated, valuePath, *incl) | ||
| if err == nil { | ||
| updated = rewritten | ||
| } | ||
| } |
There was a problem hiding this comment.
Similar to ApplyGeminiThinkingConfig, this logic does not normalize includeThoughts (camelCase) to the expected include_thoughts (snake_case) for this model family. This could lead to the setting being ignored by the API. Please consider adding normalization logic.
| if !gjson.GetBytes(updated, "generationConfig.thinkingConfig.includeThoughts").Exists() && | ||
| !gjson.GetBytes(updated, "generationConfig.thinkingConfig.include_thoughts").Exists() { | ||
| valuePath := "generationConfig.thinkingConfig.includeThoughts" | ||
| rewritten, err := sjson.SetBytes(updated, valuePath, *incl) | ||
| if err == nil { | ||
| updated = rewritten | ||
| } | ||
| } |
There was a problem hiding this comment.
While this change correctly avoids overwriting an existing key, it removes the previous (though buggy) attempt at normalization. This function is for Gemini 3 models, which expect includeThoughts (camelCase). If a request provides include_thoughts (snake_case), this new logic allows it to pass through. The API will likely ignore the setting. Please reintroduce logic to normalize include_thoughts to includeThoughts.
| if !gjson.GetBytes(updated, "request.generationConfig.thinkingConfig.includeThoughts").Exists() && | ||
| !gjson.GetBytes(updated, "request.generationConfig.thinkingConfig.include_thoughts").Exists() { | ||
| valuePath := "request.generationConfig.thinkingConfig.includeThoughts" | ||
| rewritten, err := sjson.SetBytes(updated, valuePath, *incl) | ||
| if err == nil { | ||
| updated = rewritten | ||
| } | ||
| } |
There was a problem hiding this comment.
As with ApplyGeminiThinkingLevel, this change fixes the overwriting issue but removes key normalization. For Gemini 3 models, include_thoughts should be converted to includeThoughts to ensure the API processes the setting correctly. Please add logic to handle this normalization.
| if !gjson.GetBytes(updated, "generationConfig.thinkingConfig.includeThoughts").Exists() && | ||
| !gjson.GetBytes(updated, "generationConfig.thinkingConfig.include_thoughts").Exists() { | ||
| valuePath := "generationConfig.thinkingConfig.include_thoughts" | ||
| rewritten, err := sjson.SetBytes(updated, valuePath, *incl) | ||
| if err == nil { | ||
| updated = rewritten | ||
| } | ||
| } |
There was a problem hiding this comment.
The logic to conditionally set includeThoughts is duplicated across four functions in this file (ApplyGeminiThinkingConfig, ApplyGeminiCLIThinkingConfig, ApplyGeminiThinkingLevel, ApplyGeminiCLIThinkingLevel). To improve maintainability and reduce redundancy, please consider extracting this into a single helper function.
No description provided.