Skip to content

Conversation

@zhiqing0205
Copy link

@zhiqing0205 zhiqing0205 commented Jan 5, 2026

To solve #875

A single GPT user may hold both a Plus subscription in their personal workspace and a Team subscription in a team workspace. Currently, we cannot distinguish between these two because the email address is used as the stored credential. However, the usage limits (quotas) for the two subscriptions under the same account are calculated separately.

Therefore, this pr opts to append the subscription plan name to the auth filename to distinguish between them.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @zhiqing0205, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Codex authentication system by incorporating the user's ChatGPT plan type into the filename used for storing authentication credentials. This change addresses an issue where multiple authentication files for the same user but different plan types might conflict, ensuring unique and descriptive filenames for better credential management and clarity.

Highlights

  • Plan Type Extraction: The ChatgptPlanType is now extracted from Codex JWT claims during the authentication process.
  • Dynamic Filename Generation: A new utility function, codex.CredentialFileName, has been introduced to dynamically generate authentication filenames based on email and plan type.
  • Filename Format Update: Authentication filenames for Codex credentials now include the user's plan type (e.g., [email protected]) to prevent conflicts and improve organization, addressing issue 同时使用GPT账号个人空间和团队空间 #875.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a change to include the plan type in the filename for Codex authentication credentials. This is achieved by adding a new CredentialFileName function in a new file internal/auth/codex/filename.go, and using it in internal/api/handlers/management/auth_files.go and sdk/auth/codex.go. The changes look good and correctly implement the intended feature. I have one suggestion to improve the Unicode handling in the new titleToken helper function for better robustness.

HsnSaboor added a commit to HsnSaboor/CLIProxyAPI that referenced this pull request Jan 6, 2026
…auto-update, request timeout, multi-candidate, auth persistence

Applied features from upstream PRs:
- PR router-for-me#878: Usage statistics persistence (SetPersistPath, LoadStatistics, SaveStatistics)
- PR router-for-me#877: Codex plan type credential filename handling
- PR router-for-me#868: Claude request cloaking utilities (obfuscation, fake user IDs)
- PR router-for-me#715: Auto-update command for self-updating binary
- PR router-for-me#860: Configurable request timeout with RequestTimeout config
- PR router-for-me#879: Gemini multi-candidate support (n param -> candidateCount)
- PR router-for-me#869: Auth token persistence for non-Google OAuth providers

Fixed build issues:
- Added applyPayloadConfig wrapper function
- Added originalTranslated computation in claude/antigravity/codex executors
- Fixed model registry hook methods
- Removed duplicate SanitizeFunctionName
- Fixed gemini_schema placeholder logic for nested object properties

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant