-
-
Notifications
You must be signed in to change notification settings - Fork 55
v6.6.6 #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v6.6.6 #21
Conversation
fix(codex): raise default reasoning effort to medium
Summary of ChangesHello @luispater, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on two areas: enhancing the default reasoning capabilities of AI model translations by adjusting a key configuration parameter, and significantly improving the stability and accuracy of file system event handling within the application's watcher component. The file watcher improvements address potential race conditions and inconsistencies that can arise from file system operations, particularly on Windows, by introducing path normalization and event debouncing. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request, titled 'v6.6.6', appears to be a version bump that includes several changes. The most significant change is in internal/watcher/watcher.go, where file path normalization and debouncing for remove events have been added to improve the robustness of the file watcher, particularly on Windows. Other changes include updating the default reasoning.effort from 'low' to 'medium' in several translator files and a minor code formatting fix. The changes are well-implemented and improve the codebase. I have one minor suggestion to improve maintainability in the watcher logic.
| } | ||
| } | ||
| w.lastRemoveTimes[normalizedPath] = now | ||
| if len(w.lastRemoveTimes) > 128 { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The value 128 is a magic number that determines the maximum size of the lastRemoveTimes cache. It's better to define this as a constant to improve readability and maintainability. I suggest defining a constant like authRemoveDebounceCacheSize = 128 in the const block around line 134 and using it here.
No description provided.