-
-
Notifications
You must be signed in to change notification settings - Fork 98
v6.6.24 #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v6.6.24 #40
Conversation
chore: ignore agent and bmad artifacts
…nhanced capabilities
Summary of ChangesHello @luispater, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on integrating the new 'gemini-3-flash-preview' model into the system's model registry, ensuring its availability and proper description across different platforms like Vertex AI, CLI, and AI Studio. Additionally, it refines the description of an existing Gemini model and updates ignore files to manage new development artifacts. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for the new gemini-3-flash-preview model across Vertex, CLI, and AI Studio providers. It also updates the model definition for gemini-3-pro-preview. The changes look good, but I've identified a couple of areas for improvement in internal/registry/model_definitions.go to enhance maintainability and ensure consistency. Specifically, I've suggested refactoring the duplicated model definitions and pointed out a missing field in one of them.
| ID: "gemini-3-flash-preview", | ||
| Object: "model", | ||
| Created: 1765929600, | ||
| OwnedBy: "google", | ||
| Type: "gemini", | ||
| Name: "models/gemini-3-flash-preview", | ||
| Version: "3.0", | ||
| DisplayName: "Gemini 3 Flash Preview", | ||
| Description: "Our most intelligent model built for speed, combining frontier intelligence with superior search and grounding.", | ||
| InputTokenLimit: 1048576, | ||
| OutputTokenLimit: 65536, | ||
| SupportedGenerationMethods: []string{"generateContent", "countTokens", "createCachedContent", "batchGenerateContent"}, | ||
| Thinking: &ThinkingSupport{Min: 128, Max: 32768, ZeroAllowed: false, DynamicAllowed: true}, | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This model definition for gemini-3-flash-preview is duplicated in GetGeminiCLIModels and GetAIStudioModels. To improve maintainability and reduce code duplication, consider defining this ModelInfo struct as a package-level variable and reusing it in all three functions. This would also help prevent inconsistencies, like the one I've pointed out in GetGeminiCLIModels.
| ID: "gemini-3-flash-preview", | ||
| Object: "model", | ||
| Created: 1765929600, | ||
| OwnedBy: "google", | ||
| Type: "gemini", | ||
| Name: "models/gemini-3-flash-preview", | ||
| Version: "3.0", | ||
| DisplayName: "Gemini 3 Flash Preview", | ||
| Description: "Our most intelligent model built for speed, combining frontier intelligence with superior search and grounding.", | ||
| InputTokenLimit: 1048576, | ||
| OutputTokenLimit: 65536, | ||
| SupportedGenerationMethods: []string{"generateContent", "countTokens", "createCachedContent", "batchGenerateContent"}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Thinking field is missing for the gemini-3-flash-preview model in GetGeminiCLIModels. This field is present for the same model in GetGeminiVertexModels and GetAIStudioModels, and was just added for gemini-3-pro-preview in this same function. For consistency and to ensure correct functionality, it should be added here as well.
| ID: "gemini-3-flash-preview", | |
| Object: "model", | |
| Created: 1765929600, | |
| OwnedBy: "google", | |
| Type: "gemini", | |
| Name: "models/gemini-3-flash-preview", | |
| Version: "3.0", | |
| DisplayName: "Gemini 3 Flash Preview", | |
| Description: "Our most intelligent model built for speed, combining frontier intelligence with superior search and grounding.", | |
| InputTokenLimit: 1048576, | |
| OutputTokenLimit: 65536, | |
| SupportedGenerationMethods: []string{"generateContent", "countTokens", "createCachedContent", "batchGenerateContent"}, | |
| ID: "gemini-3-flash-preview", | |
| Object: "model", | |
| Created: 1765929600, | |
| OwnedBy: "google", | |
| Type: "gemini", | |
| Name: "models/gemini-3-flash-preview", | |
| Version: "3.0", | |
| DisplayName: "Gemini 3 Flash Preview", | |
| Description: "Our most intelligent model built for speed, combining frontier intelligence with superior search and grounding.", | |
| InputTokenLimit: 1048576, | |
| OutputTokenLimit: 65536, | |
| SupportedGenerationMethods: []string{"generateContent", "countTokens", "createCachedContent", "batchGenerateContent"}, | |
| Thinking: &ThinkingSupport{Min: 128, Max: 32768, ZeroAllowed: false, DynamicAllowed: true}, |
No description provided.