Skip to content

Conversation

@luispater
Copy link

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello @luispater, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on integrating the new 'gemini-3-flash-preview' model into the system's model registry, ensuring its availability and proper description across different platforms like Vertex AI, CLI, and AI Studio. Additionally, it refines the description of an existing Gemini model and updates ignore files to manage new development artifacts.

Highlights

  • New Model Integration: The 'gemini-3-flash-preview' model has been added to the model registry, making it available for use across Vertex AI, CLI, and AI Studio contexts.
  • Model Description Enhancement: The description for the 'gemini-3-pro-preview' model has been updated to provide more detailed capabilities and features.
  • Configuration Updates: The .dockerignore and .gitignore files have been updated to exclude new directories/files, specifically .agent/* and _bmad/*, from being included in Docker builds and version control.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@luispater luispater merged commit 0155a01 into router-for-me:main Dec 17, 2025
1 check passed
@luispater luispater deleted the plus branch December 17, 2025 17:04
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the new gemini-3-flash-preview model across Vertex, CLI, and AI Studio providers. It also updates the model definition for gemini-3-pro-preview. The changes look good, but I've identified a couple of areas for improvement in internal/registry/model_definitions.go to enhance maintainability and ensure consistency. Specifically, I've suggested refactoring the duplicated model definitions and pointed out a missing field in one of them.

Comment on lines +246 to +259
ID: "gemini-3-flash-preview",
Object: "model",
Created: 1765929600,
OwnedBy: "google",
Type: "gemini",
Name: "models/gemini-3-flash-preview",
Version: "3.0",
DisplayName: "Gemini 3 Flash Preview",
Description: "Our most intelligent model built for speed, combining frontier intelligence with superior search and grounding.",
InputTokenLimit: 1048576,
OutputTokenLimit: 65536,
SupportedGenerationMethods: []string{"generateContent", "countTokens", "createCachedContent", "batchGenerateContent"},
Thinking: &ThinkingSupport{Min: 128, Max: 32768, ZeroAllowed: false, DynamicAllowed: true},
},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This model definition for gemini-3-flash-preview is duplicated in GetGeminiCLIModels and GetAIStudioModels. To improve maintainability and reduce code duplication, consider defining this ModelInfo struct as a package-level variable and reusing it in all three functions. This would also help prevent inconsistencies, like the one I've pointed out in GetGeminiCLIModels.

Comment on lines +342 to 353
ID: "gemini-3-flash-preview",
Object: "model",
Created: 1765929600,
OwnedBy: "google",
Type: "gemini",
Name: "models/gemini-3-flash-preview",
Version: "3.0",
DisplayName: "Gemini 3 Flash Preview",
Description: "Our most intelligent model built for speed, combining frontier intelligence with superior search and grounding.",
InputTokenLimit: 1048576,
OutputTokenLimit: 65536,
SupportedGenerationMethods: []string{"generateContent", "countTokens", "createCachedContent", "batchGenerateContent"},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The Thinking field is missing for the gemini-3-flash-preview model in GetGeminiCLIModels. This field is present for the same model in GetGeminiVertexModels and GetAIStudioModels, and was just added for gemini-3-pro-preview in this same function. For consistency and to ensure correct functionality, it should be added here as well.

Suggested change
ID: "gemini-3-flash-preview",
Object: "model",
Created: 1765929600,
OwnedBy: "google",
Type: "gemini",
Name: "models/gemini-3-flash-preview",
Version: "3.0",
DisplayName: "Gemini 3 Flash Preview",
Description: "Our most intelligent model built for speed, combining frontier intelligence with superior search and grounding.",
InputTokenLimit: 1048576,
OutputTokenLimit: 65536,
SupportedGenerationMethods: []string{"generateContent", "countTokens", "createCachedContent", "batchGenerateContent"},
ID: "gemini-3-flash-preview",
Object: "model",
Created: 1765929600,
OwnedBy: "google",
Type: "gemini",
Name: "models/gemini-3-flash-preview",
Version: "3.0",
DisplayName: "Gemini 3 Flash Preview",
Description: "Our most intelligent model built for speed, combining frontier intelligence with superior search and grounding.",
InputTokenLimit: 1048576,
OutputTokenLimit: 65536,
SupportedGenerationMethods: []string{"generateContent", "countTokens", "createCachedContent", "batchGenerateContent"},
Thinking: &ThinkingSupport{Min: 128, Max: 32768, ZeroAllowed: false, DynamicAllowed: true},

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants