v6.6.50 #59
v6.6.50 #59
Conversation
…pare in hasModelMappingsChanged; removed boolTo01. • Performance: pre-allocate map and regex slice capacities in UpdateMappings. • Verified with amp module tests (all passing)
feat: regex support for model-mappings
feat(logging): implement request ID tracking and propagation
Summary of ChangesHello @luispater, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the observability and flexibility of the API by implementing a comprehensive request ID tracking system and extending the model mapping capabilities. The new request ID feature provides end-to-end traceability for AI API calls, while the addition of regular expression support for AMP model mappings allows for more dynamic and sophisticated routing configurations. These changes collectively improve debugging, monitoring, and model management within the system. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces two main enhancements: request ID tracking for improved logging and traceability of AI API requests, and support for regex-based model mappings in the AMP module. The changes span across logging, middleware, and module-specific logic to integrate these features. The request ID is now generated for specific API paths and propagated through the request context, appearing in both console logs and request log files. The AMP model mapper can now use regular expressions for more flexible model routing. Overall, the changes are well-implemented. I have one suggestion to improve logging consistency.
| func logEntryWithRequestID(ctx context.Context) *log.Entry { | ||
| if ctx == nil { | ||
| return log.NewEntry(log.StandardLogger()) | ||
| } | ||
| if reqID := logging.GetRequestID(ctx); reqID != "" { | ||
| return log.WithField("request_id", reqID) | ||
| } | ||
| return log.NewEntry(log.StandardLogger()) | ||
| } |
There was a problem hiding this comment.
For consistency with the Gin logger, which uses a '--------' placeholder for requests without a request ID, this function should also add a placeholder. This ensures all log lines have a consistent structure, making them easier to parse and read.
| func logEntryWithRequestID(ctx context.Context) *log.Entry { | |
| if ctx == nil { | |
| return log.NewEntry(log.StandardLogger()) | |
| } | |
| if reqID := logging.GetRequestID(ctx); reqID != "" { | |
| return log.WithField("request_id", reqID) | |
| } | |
| return log.NewEntry(log.StandardLogger()) | |
| } | |
| func logEntryWithRequestID(ctx context.Context) *log.Entry { | |
| reqID := "--------" | |
| if ctx != nil { | |
| if id := logging.GetRequestID(ctx); id != "" { | |
| reqID = id | |
| } | |
| } | |
| return log.WithField("request_id", reqID) | |
| } |
2 participants
No description provided.